pylint fix

buildbot · Jan 24, 2017 · 7c38da9 · 7c38da9
1 parent 9a59745
commit 7c38da9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/master/buildbot/changes/base.py b/master/buildbot/changes/base.py
@@ -96,8 +96,8 @@ def deactivate(self):
 
 
 class PollingChangeSource(ReconfigurablePollingChangeSource):
-    # Legacy code will be very painful to port to BuildbotService lifecyle
-    # because the unit tests keep doing shortcuts for the Service lifecycle (i.e by no calling startService)
+    # Legacy code will be very painful to port to BuildbotService life cycle
+    # because the unit tests keep doing shortcuts for the Service life cycle (i.e by no calling startService)
     # instead of porting everything at once, we make a class to support legacy
 
     def checkConfig(self, name=None, pollInterval=60 * 10, pollAtLaunch=False):

diff --git a/master/buildbot/test/integration/test_integration_scheduler_reconfigure.py b/master/buildbot/test/integration/test_integration_scheduler_reconfigure.py
@@ -60,7 +60,7 @@ def masterConfig():
     c = {}
     from buildbot.config import BuilderConfig
     from buildbot.process.factory import BuildFactory
-    from buildbot.plugins import steps, schedulers
+    from buildbot.plugins import steps
 
     c['schedulers'] = [
         schedulers.AnyBranchScheduler(

diff --git a/master/buildbot/test/unit/test_changes_base.py b/master/buildbot/test/unit/test_changes_base.py
@@ -158,7 +158,7 @@ def test_poll_only_if_activated(self):
 
         @d.addCallback
         def check(_):
-            # it doesnt do anything because it was already claimed
+            # it doesn't do anything because it was already claimed
             self.assertEqual(loops, [])
 
         reactor.callWhenRunning(d.callback, None)
@@ -259,7 +259,7 @@ def test_poll_only_if_activated(self):
 
         yield self.runClockFor(12)
 
-        # it doesnt do anything because it was already claimed
+        # it doesn't do anything because it was already claimed
         self.assertEqual(loops, [])
 
     @defer.inlineCallbacks

diff --git a/master/buildbot/test/unit/test_schedulers_manager.py b/master/buildbot/test/unit/test_schedulers_manager.py
@@ -76,8 +76,10 @@ def still_set(_):
                 assert self.objectid is not None
             d.addCallback(still_set)
             return d
+
         def __repr__(self):
             return "{}(attr={})".format(self.__class__.__name__, self.attr)
+
     class ReconfigSched(Sched):
 
         def reconfigServiceWithSibling(self, new_config):