Skip to content

Commit

Permalink
header line-ending checks were too aggressive
Browse files Browse the repository at this point in the history
  • Loading branch information
djmitche committed Dec 29, 2013
1 parent 63505a1 commit 8170e2f
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions master/buildbot/test/fake/logfile.py
Expand Up @@ -43,28 +43,25 @@ def subscribe(self, callback):
return self.subPoint.subscribe(callback)

def addHeader(self, text):
assert text.endswith('\n')
self.header += text
self.chunks.append((HEADER, text))
if self.name in self.step.logobservers:
for obs in self.step.logobservers[self.name]:
obs.headerReceived(text.decode('utf-8'))
obs.headerReceived(text)

def addStdout(self, text):
assert text.endswith('\n')
self.stdout += text
self.chunks.append((STDOUT, text))
if self.name in self.step.logobservers:
for obs in self.step.logobservers[self.name]:
obs.outReceived(text.decode('utf-8'))
obs.outReceived(text)

def addStderr(self, text):
assert text.endswith('\n')
self.stderr += text
self.chunks.append((STDERR, text))
if self.name in self.step.logobservers:
for obs in self.step.logobservers[self.name]:
obs.errReceived(text.decode('utf-8'))
obs.errReceived(text)

def isFinished(self):
return self.finished
Expand Down

0 comments on commit 8170e2f

Please sign in to comment.