Skip to content

Commit

Permalink
make branch and codebase renderable
Browse files Browse the repository at this point in the history
  • Loading branch information
djmitche committed Nov 5, 2013
1 parent ba7dcc3 commit 873dfb0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion master/buildbot/steps/source/git.py
Expand Up @@ -58,7 +58,7 @@ def isTrueOrIsExactlyZero(v):
class Git(Source):
""" Class for Git with all the smarts """
name='git'
renderables = [ "repourl", "reference"]
renderables = [ "repourl", "reference", "branch", "codebase"]

def __init__(self, repourl=None, branch='HEAD', mode='incremental', method=None,
reference=None, submodules=False, shallow=False, progress=False, retryFetch=False,
Expand Down
2 changes: 2 additions & 0 deletions master/docs/relnotes/index.rst
Expand Up @@ -123,6 +123,8 @@ Features

* A new argument ``createAbsoluteSourceStamps`` has been added to :bb:sched:`Nightly` for use with multiple codebases.

* The ``branch`` and ``codebase`` arguments to the :bb:step:`Git` step are now renderable.

Fixes
~~~~~

Expand Down

2 comments on commit 873dfb0

@pepsiman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only for Git?

@djmitche
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lazy - the rest would be great to have, too. Making attributes renderable is basically always a good idea.

Please sign in to comment.