always return new (cloned) objects if absolute sourcestamps have been…

… requested
buildbot · May 8, 2012 · 8946eba · 8946eba
1 parent 9995410
commit 8946eba
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/master/buildbot/status/build.py b/master/buildbot/status/build.py
@@ -98,16 +98,20 @@ def getAllGotRevisions(self):
 
     def getSourceStamps(self, absolute=False):
         sourcestamps = []
-        all_got_revisions = self.getAllGotRevisions()
-        if not absolute or not all_got_revisions:
+        if not absolute:
             sourcestamps.extend(self.sources)
         else:
+            all_got_revisions = self.getAllGotRevisions()
+            # always make a new instance
             for ss in self.sources:
                 if ss.codebase in all_got_revisions:
                     got_revision = all_got_revisions[ss.codebase]
                     sourcestamps.append(ss.getAbsoluteSourceStamp(got_revision))
                 else:
-                    sourcestamps.append(ss)
+                    # No absolute revision information available
+                    # Probably build has been stopped before ending all sourcesteps
+                    # Return a clone with original revision
+                    sourcestamps.append(ss.clone())
         return sourcestamps
 
     def getReason(self):