Skip to content

Commit

Permalink
Remove unnecessary encoding of command.
Browse files Browse the repository at this point in the history
Encoding to bytes happens later on, before command is executed.
  • Loading branch information
rodrigc committed Sep 6, 2017
1 parent 28964a6 commit 9250b3c
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions master/buildbot/steps/source/p4.py
Expand Up @@ -234,15 +234,6 @@ def _buildVCCommand(self, doCommand):
command.extend(self.p4extra_args)

command.extend(doCommand)

def encodeArg(arg):
if isinstance(arg, tuple):
# If a tuple, then the second element is the argument that will
# be used when executing the command.
return (arg[0], util.encodeString(arg[1]), arg[2])
return util.encodeString(arg)

command = [encodeArg(c) for c in command]
return command

def _dovccmd(self, command, collectStdout=False, initialStdin=None):
Expand Down

0 comments on commit 9250b3c

Please sign in to comment.