Skip to content

Commit

Permalink
fix color for step mouseover popup
Browse files Browse the repository at this point in the history 
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
  • Loading branch information
Pierre Tardy committed Aug 27, 2014
1 parent a0464ec commit 93244ef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion www/waterfall_view/src/module/main.module.coffee
View file
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ class Waterfall extends Controller
.append('text')
.attr('y', (step, i) -> 15 * (i + 1))
.attr('x', if r then 30 else 10)
.attr('class', color)
.attr('class', (step, i) -> self.result(step))
.classed('fill', true)
.transition().delay(100)
# Text format
Expand Down

7 comments on commit 93244ef

@tothandras
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attr('class', self.result) doesn't work?

@tardyp
Copy link
Member

@tardyp tardyp commented on 93244ef Aug 27, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tothandras
Copy link
Member

@tothandras tothandras commented on 93244ef Aug 27, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tardyp
Copy link
Member

@tardyp tardyp commented on 93244ef Aug 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh. I did not understand in the first place. for me it is not obvious when you read attr('class', self.result) that self.result is a function that extracts the class from the step.

@tothandras
Copy link
Member

@tothandras tothandras commented on 93244ef Aug 27, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tothandras
Copy link
Member

@tothandras tothandras commented on 93244ef Aug 27, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tardyp
Copy link
Member

@tardyp tardyp commented on 93244ef Aug 27, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.