Skip to content

Commit

Permalink
Store revs in ascii strings, not unicode.
Browse files Browse the repository at this point in the history
This is to avoid Twisted complaining about unicode arguments being
passed to reactor.spawnProcess.

Also: release notes

Conflicts:
	master/buildbot/changes/gitpoller.py
  • Loading branch information
jpommerening authored and Xavier Delannoy committed Dec 10, 2014
1 parent 855c748 commit a1819ba
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions master/buildbot/changes/gitpoller.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,10 @@ def poll(self):
log.msg('gitpoller: processing changes from "%s"' % (self.repourl,))
for branch in branches:
try:
revs[branch] = rev = yield self._dovccmd(
rev = yield self._dovccmd(
'rev-parse', [self._trackerBranch(branch)], path=self.workdir)
yield self._process_changes(rev, branch)
revs[branch] = str(rev)
yield self._process_changes(revs[branch], branch)
except Exception:
log.err(_why="trying to poll branch %s of %s"
% (branch, self.repourl))
Expand Down

0 comments on commit a1819ba

Please sign in to comment.