data: remove unnecessary deferred in test_results.db2data

buildbot · May 21, 2024 · a48ad8a · a48ad8a
1 parent d4bd459
commit a48ad8a
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/master/buildbot/data/test_results.py b/master/buildbot/data/test_results.py
@@ -29,7 +29,7 @@
 
 class Db2DataMixin:
     def db2data(self, model: TestResultModel):
-        data = {
+        return {
             'test_resultid': model.id,
             'builderid': model.builderid,
             'test_result_setid': model.test_result_setid,
@@ -39,7 +39,6 @@ def db2data(self, model: TestResultModel):
             'duration_ns': model.duration_ns,
             'value': model.value,
         }
-        return defer.succeed(data)
 
 
 class TestResultsEndpoint(Db2DataMixin, base.Endpoint):
@@ -61,10 +60,7 @@ def get(self, resultSpec, kwargs):
             set_dbdict['builderid'], kwargs['test_result_setid'], result_spec=resultSpec
         )
 
-        results = []
-        for dbdict in result_dbdicts:
-            results.append((yield self.db2data(dbdict)))
-        return results
+        return [self.db2data(result) for result in result_dbdicts]
 
 
 class TestResult(base.ResourceType):