perform method check before using it

buildbot · Jan 22, 2015 · a872645 · a872645
1 parent 1a7b2c1
commit a872645
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/master/buildbot/steps/http.py b/master/buildbot/steps/http.py
@@ -72,14 +72,16 @@ class HTTPStep(BuildStep):
     def __init__(self, url, method, **kwargs):
         if txrequests is None or requests is None:
             config.error("Need to install txrequest to use this step:\n\n pip install txrequests")
+
+        if method not in ('POST', 'GET', 'PUT', 'DELETE', 'HEAD', 'OPTIONS'):
+            config.error("Wrong method given: '%s' is not known" % method)
+
         self.method = method
         self.url = url
         self.requestkwargs = {'method': method, 'url': url}
         for p in HTTPStep.requestsParams:
             v = kwargs.pop(p, None)
             self.__dict__[p] = v
-        if method not in ('POST', 'GET', 'PUT', 'DELETE', 'HEAD', 'OPTIONS'):
-            config.error("Wrong method given: '%s' is not known" % method)
 
         BuildStep.__init__(self, **kwargs)