Skip to content

Commit

Permalink
web change hook: rename exception variable name
Browse files Browse the repository at this point in the history
Use a more descriptive name of the cought instance of ValueError
exception. The generic 'err' was redefined as a local function
on line 81.

This fixes pylint error 'E0102 (function-redefined)' in this file.
  • Loading branch information
Elmir Jagudin committed Aug 23, 2013
1 parent 529c3f8 commit a973e2f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions master/buildbot/status/web/change_hook.py
Expand Up @@ -60,9 +60,9 @@ def render_POST(self, request):

try:
changes, src = self.getChanges( request )
except ValueError, err:
request.setResponseCode(400, err.args[0])
return err.args[0]
except ValueError, val_err:
request.setResponseCode(400, val_err.args[0])
return val_err.args[0]
except Exception, e:
log.err(e, "processing changes from web hook")
msg = "Error processing changes."
Expand Down

0 comments on commit a973e2f

Please sign in to comment.