Capture and log errors during cleanup

buildbot · Apr 22, 2012 · aed46b6 · aed46b6
1 parent b003e14
commit aed46b6
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/master/buildbot/process/builder.py b/master/buildbot/process/builder.py
@@ -262,9 +262,12 @@ def _startBuildFor(self, slavebuilder, buildrequests):
         # into a list so that, at any point, we can abort this operation.
         cleanups = []
         def run_cleanups():
-            while cleanups:
-                fn = cleanups.pop()
-                fn()
+            try:
+                while cleanups:
+                    fn = cleanups.pop()
+                    fn()
+            except:
+                log.err(failure.Failure(), "while running %r" % (run_cleanups,))
 
         # the last cleanup we want to perform is to update the big
         # status based on any other cleanup