Skip to content

Commit

Permalink
Merge pull request #1386 from benallard/patch-3
Browse files Browse the repository at this point in the history
Fix BuildProperty row name (set singular)
  • Loading branch information
Mikhail Sobolev committed Nov 26, 2014
2 parents fc5adc8 + 9bfc0fb commit aeee708
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion master/buildbot/test/fake/fakedb.py
Expand Up @@ -463,7 +463,7 @@ class Build(Row):
required_columns = ('buildrequestid', 'masterid', 'buildslaveid')


class BuildProperties(Row):
class BuildProperty(Row):
table = "build_properties"
defaults = dict(
buildid=None,
Expand Down Expand Up @@ -1723,6 +1723,11 @@ def insertTestData(self, rows):
build = self.builds[row.id] = row.values.copy()
build['properties'] = {}

for row in rows:
if isinstance(row, BuildProperty):
assert row.buildid in self.builds
self.builds[row.buildid]['properties'][row.name] = (row.value, row.source)

# component methods

def _newId(self):
Expand Down

0 comments on commit aeee708

Please sign in to comment.