Better logging of errors from web change hooks.

The error message was getting discarded, making debugging impossible.
buildbot · Oct 2, 2012 · bfdb69e · bfdb69e
1 parent a415efa
commit bfdb69e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/master/buildbot/status/web/change_hook.py b/master/buildbot/status/web/change_hook.py
@@ -63,8 +63,8 @@ def render_POST(self, request):
         except ValueError, err:
             request.setResponseCode(400, err.args[0])
             return err.args[0]
-        except Exception:
-            log.err(None, "Exception processing web hook.")
+        except Exception, e:
+            log.err(e, "processing changes from web hook")
             msg = "Error processing changes."
             request.setResponseCode(500, msg)
             return msg
@@ -78,7 +78,8 @@ def render_POST(self, request):
         def ok(_):
             request.setResponseCode(202)
             request.finish()
-        def err(_):
+        def err(why):
+            log.err(why, "adding changes from web hook")
             request.setResponseCode(500)
             request.finish()
         d.addCallbacks(ok, err)