Skip to content

Commit

Permalink
Merge branch 'buck-fix-github' of git://github.com/bukzor/buildbot
Browse files Browse the repository at this point in the history
  • Loading branch information
djmitche committed Aug 12, 2013
2 parents 344d859 + bde326c commit ca5353e
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions master/buildbot/test/unit/test_status_github.py
Expand Up @@ -152,7 +152,7 @@ def test_buildStarted_success(self):

result = self.status.buildStarted(builder_name, build)

self.assertIsNone(result)
self.assertIdentical(result, None)
self.status._sendStartStatus.assert_called_once_with(
builder_name, build)

Expand All @@ -167,7 +167,7 @@ def test_buildStarted_failure(self):

result = self.status.buildStarted(builder_name, None)

self.assertIsNone(result)
self.assertIdentical(result, None)
self.assertLogError(
error,
'While sending start status to GitHub for builder-name.')
Expand All @@ -183,7 +183,7 @@ def test_buildFinished_success(self):

result = self.status.buildFinished(builder_name, build, results)

self.assertIsNone(result)
self.assertIdentical(result, None)
self.status._sendFinishStatus.assert_called_once_with(
builder_name, build, results)

Expand All @@ -198,7 +198,7 @@ def test_buildFinished_failure(self):

result = self.status.buildFinished(builder_name, None, None)

self.assertIsNone(result)
self.assertIdentical(result, None)
self.assertLogError(
error,
'While sending finish status to GitHub for builder-name.')
Expand All @@ -213,7 +213,7 @@ def test_sendStartStatus_no_properties(self):
d = self.status._sendStartStatus('builder-name', None)
result = self.successResultOf(d)

self.assertIsNone(result)
self.assertIdentical(result, None)

def test_sendStartStatus_failure(self):
"""
Expand Down Expand Up @@ -247,7 +247,7 @@ def test_sendStartStatus_ok(self):
d = self.status._sendStartStatus('builder-name', self.build)
result = self.successResultOf(d)

self.assertIsNone(result)
self.assertIdentical(result, None)
self.status._sendGitHubStatus.assert_called_with({
'repoOwner': 'repo-owner',
'repoName': 'repo-name',
Expand Down Expand Up @@ -285,7 +285,7 @@ def test_sendFinishStatus_failure(self):
d = self.status._sendFinishStatus('builder-name', None, None)
result = self.successResultOf(d)

self.assertIsNone(result)
self.assertIdentical(result, None)

def test_sendFinishStatus_ok(self):
"""
Expand All @@ -307,7 +307,7 @@ def test_sendFinishStatus_ok(self):
d = self.status._sendFinishStatus('builder-name', self.build, SUCCESS)
result = self.successResultOf(d)

self.assertIsNone(result)
self.assertIdentical(result, None)
self.status._sendGitHubStatus.assert_called_with({
'repoOwner': 'repo-owner',
'repoName': 'repo-name',
Expand Down

0 comments on commit ca5353e

Please sign in to comment.