Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
TryClient: Don't pass empty diff to buildbot.
We created a source stamp with patch being an empty string. Instead, create a source stamp without a patch. Signed-off-by: Tom Prince <tom.prince@ualberta.net>
- Loading branch information
e3ac692
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Forcing diff = None at lines 430/431 breaks a use case I have for triggering builds with special properties set. I have been using:
buildbot try --diff /dev/null
but this change breaks that usage.
e3ac692
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use 'buildbot sendchange' instead?
e3ac692
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.