Skip to content

Commit

Permalink
Fix issue when several mail notifiers are used with same parameters, …
Browse files Browse the repository at this point in the history
…but different modes

fixes #3398
  • Loading branch information
tardyp committed Jul 4, 2017
1 parent cc566d1 commit e4c125a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions master/buildbot/newsfragments/mailnotifier_modes.bugfix
@@ -0,0 +1 @@
Fix issue when several mail notifiers are used with same parameters, but different modes (:issue:`3398`).
1 change: 1 addition & 0 deletions master/buildbot/reporters/notifier.py
Expand Up @@ -80,6 +80,7 @@ def checkConfig(self, mode=("failing", "passing", "warnings"),
self.name += "_schedulers_" + "+".join(schedulers)
if branches is not None:
self.name += "_branches_" + "+".join(branches)
self.name += "_".join(mode)

if '\n' in subject:
config.error(
Expand Down

0 comments on commit e4c125a

Please sign in to comment.