Fix default status handling in MasterShellCommand

Now flunkOnFailure and haltOnFailure default to True
buildbot · Jan 1, 2011 · ea8407f · ea8407f
1 parent 67ec0ec
commit ea8407f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/master/NEWS b/master/NEWS
@@ -13,6 +13,10 @@ their default.css file has already been created. If you currently use the
 default and want to get the new version, just overwrite public_html/default.css
 with the copy in this version.
 
+** Deprecations, Removals, and Non-Compatible Changes
+
+*** MasterShellCommand now defaults to haltOnFailure=True and
+flunkOnFailure=True
 
 * Buildbot 0.8.3 (December 19, 2010)
 

diff --git a/master/buildbot/steps/master.py b/master/buildbot/steps/master.py
@@ -24,11 +24,13 @@ class MasterShellCommand(BuildStep):
     """
     Run a shell command locally - on the buildmaster.  The shell command
     COMMAND is specified just as for a RemoteShellCommand.  Note that extra
-    logfiles are not sopported.
+    logfiles are not supported.
     """
     name='MasterShellCommand'
     description='Running'
     descriptionDone='Ran'
+    haltOnFailure = True
+    flunkOnFailure = True
 
     def __init__(self, command,
                  description=None, descriptionDone=None,