Class methods replaces by dict.get() method

buildbot · Apr 25, 2012 · fbd0bcc · fbd0bcc
1 parent 2734a70
commit fbd0bcc
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/master/buildbot/schedulers/base.py b/master/buildbot/schedulers/base.py
@@ -182,17 +182,6 @@ def getPendingBuildTimes(self):
         "Returns a list of the next times that builds are scheduled, if known."
         return []
 
-    ## codebase related methods
-    ## to have the code less dependent from input structure
-    def getRepository(self, codebase):
-        return self.codebases[codebase]['repository']
-
-    def getBranch(self, codebase):
-        return self.codebases[codebase].get('branch', None)
-
-    def getRevision(self, codebase):
-        return self.codebases[codebase].get('revision', None)
-
     ## change handling
 
     def startConsumingChanges(self, fileIsImportant=None, change_filter=None,
@@ -378,9 +367,9 @@ def get_last_change_for_codebase(codebase):
                 if codebase not in changesByCodebase:
                     # codebase has no changes
                     # create a sourcestamp that has no changes
-                    repository = self.getRepository(codebase)
-                    branch = self.getBranch(codebase)
-                    revision = self.getRevision(codebase)
+                    repository = self.codebases[codebase]['repository']
+                    branch = self.codebases[codebase].get('branch', None)
+                    revision = self.codebases[codebase].get('revision', None)
                     yield self.master.db.sourcestamps.addSourceStamp(
                             codebase=codebase,
                             repository=repository,