-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gulp "processindex" command work under Windows #3359
Conversation
ProcessIndex command was using single quotes around the index.html file path, need double quotes to work on Windows. Tested double quotes under Ubuntu and still worked there.
…ning how newsfragments work, since it was not clear that the newsfragments get deleted when published -- fact that the directory was nearly empty lead me to assume that news fragments were an unused feature.
Yup, I think processIndex and ConsoleView improvements - two different PR |
@Frodox This is a new PR off a branch that I created. I created this branch off an older commit (before I started my console UI changes. I don't see any console UI changes in the 3 commits listed in this pull request. Seems like the tests start failing on the change where I added the news fragment. Not clear why. |
Codecov Report
@@ Coverage Diff @@
## master #3359 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 322 322
Lines 33441 33441
=======================================
Hits 29506 29506
Misses 3935 3935 Continue to review full report at Codecov.
|
I fixed your release note |
I think the issue here is that it is spell-checknig my news fragment, and does not like that i used the word "processindex".
I will try backquoting the identifier. There's also some other test failing due to a timeout -- I don't think that has anything to do with my changes. https://nine.buildbot.net/#/builders/10/builds/639/steps/7/logs/stdio |
Oh, thanks @tardyp ! Did not see your comment from earlier! |
eh no problem. Congratz for your first GH contribution!! |
ProcessIndex command was using single quotes around the index.html file
path, need double quotes to work on Windows. Tested double quotes
under Ubuntu and still worked there.
Contributor Checklist:
master/buildbot/newsfragment
directory (and read theREADME.txt
in that directory)