workers should be able to automatically delete leftover directory

[aj062]

Buildbot worker prints a warning about leftover directory:

[Broker,client] I have a leftover directory 'xyz-tests' that is not being used by the buildmaster: you can delete it now

Reference: https://github.com/buildbot/buildbot/blob/master/worker/buildbot_worker/base.py#L299

In large setups where configuration is dynamic and workers connect to different builders and builders change over time, it becomes a huge manual tasks to keep track of left-over directories and manually delete them.

Buildbot worker should have an option to delete such left-over directories, (probably configurable somewhere, e.g. buildbot.tac or master.cfg)

[gpshead]

The lack of this behavior took two of my buildbots offline after the master made a configuration change that altered the directory suffixes used.

Instead of logging I have a leftover directory 'BLAH' that is not being used by the buildmaster: you can delete it now to a log file no human is going to monitor, just call shutil.rmtree() on it.

buildbot/worker/buildbot_worker/base.py

Line 298 in cc304b5

log.msg("I have a leftover directory '{0}' that is not "

is where it'd be done.

(as seen due to python/buildmaster-config#108 and https://bugs.python.org/issue38269)

[mojca]

#4750

[mojca]

Sorry for the too short response last time. I would be in favour of automatically cleaning things up, one just needs to be careful enough to not delete stuff that's still being used (two builders may use the same dir, for example; even though I might want a clean-up anyway), and that users might actually want to delete stuff which should have been removed before this functionality will be implemented.

[aj062]

Seems like this is fixed by https://github.com/buildbot/buildbot/pull/5160/files

[p12tic]

Indeed.