Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build config suffixes #108

Merged
merged 1 commit into from Sep 18, 2019
Merged

Fix build config suffixes #108

merged 1 commit into from Sep 18, 2019

Conversation

stratakis
Copy link
Contributor

Build configs that inherit from the same configuration need a suffix in order
to not duplicate the build directory

master/custom/factories.py Outdated Show resolved Hide resolved
master/custom/factories.py Outdated Show resolved Hide resolved
master/custom/factories.py Outdated Show resolved Hide resolved
master/custom/factories.py Outdated Show resolved Hide resolved
Build configs that inherit from the same configuration need a suffix in order
to not duplicate the build directory
@vstinner
Copy link
Member

Thanks. I merged your PR.

@gpshead
Copy link
Member

gpshead commented Sep 25, 2019

This PR caused a bunch of build slave's disks to fill up by abandoning their old build directories and creating new ones. https://bugs.python.org/issue38269

It also contains a typo in at least one of the names.

@vstinner
Copy link
Member

This PR caused a bunch of build slave's disks to fill up by abandoning their old build directories and creating new ones.

Oh, I didn't expect this side effect. Should we contact buildbot owners to ask them to cleanup old directories?

It also contains a typo in at least one of the names.

Oh, ".clang-usban" should be ".clang-ubsan". Did you see other typos?

I wrote #112 to fix the typo. I understand that you will have to remove the old directory once this PR will be merged (and deployed)

@gpshead
Copy link
Member

gpshead commented Sep 25, 2019

If we've got a mailing list of all bot owners maybe send a note "by the way, check for unused build directories and remove them" on your bots. Otherwise, it is probably easiest to just wait for other bots to fall over. My VMs have a "small" 10gig default vm disk size.

the buildbot project appears to already have an issue open asking for it to auto-delete. i nudged that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants