Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addURL can't handle non-ascii characters #4717

Open
aj062 opened this issue Apr 11, 2019 · 1 comment
Open

addURL can't handle non-ascii characters #4717

aj062 opened this issue Apr 11, 2019 · 1 comment
Labels

Comments

@aj062
Copy link
Contributor

aj062 commented Apr 11, 2019

addURL can't handle non-ascii characters

Following command reproduces the issue:
self.addURL('\xe2\x8c\xa5', '')
result:

2019-04-11 07:41:13-0400 [-] from an asynchronous method executed in an old-style step 
        Traceback (most recent call last):
          File "steps.py", line 333, in _mystep
            self.addURL('\xe2\x8c\xa5', '')
          File "/Library/Python/2.7/site-packages/buildbot/process/buildstep.py", line 122, in wrap 
            d = fn(self, *args, **kwargs)
          File "/Library/Python/2.7/site-packages/twisted/internet/defer.py", line 1613, in unwindGenerator
            return _cancellableInlineCallbacks(gen)
          File "/Library/Python/2.7/site-packages/twisted/internet/defer.py", line 1529, in _cancellableInlineCallbacks
            _inlineCallbacks(None, g, status)
        --- <exception caught here> ---
          File "/Library/Python/2.7/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
            result = g.send(result)
          File "/Library/Python/2.7/site-packages/buildbot/process/buildstep.py", line 892, in addURL
            yield self.master.data.updates.addStepURL(self.stepid, text_type(name), text_type(url))
        exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 0: ordinal not in range(128)

@p12tic p12tic added the feature label Apr 25, 2019
@senyai
Copy link
Contributor

senyai commented Oct 24, 2020

It must be python 2.7 issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants