Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazylogfiles broken on 3.0.2 #5957

Closed
tonyhutter opened this issue Mar 29, 2021 · 2 comments · Fixed by #5970
Closed

lazylogfiles broken on 3.0.2 #5957

tonyhutter opened this issue Mar 29, 2021 · 2 comments · Fixed by #5970
Labels
bug

Comments

@tonyhutter
Copy link
Contributor

I'm upgrading from 0.8.x to 3.0.2, and have this:

test_factory = util.BuildFactory()

test_factory.addStep(ShellCommand(
    env={'PATH' : bin_path},
    command=["runurl", bb_url + "bb-dependencies.sh"],
    decodeRC={0 : SUCCESS, 1 : FAILURE, 2 : WARNINGS, 3 : SKIPPED },
    haltOnFailure=True, logEnviron=False,
    lazylogfiles=True,
    description=["installing dependencies"],
    descriptionDone=["installed dependencies"]))

Which gives me:

2021-03-26 18:38:03+0000 [-]   Invalid argument(s) passed to ShellCommand: lazylogfiles

According to the 3.0.2 documentation, lazylogfiles is a valid parameter for ShellCommand
http://docs.buildbot.net/3.0.2/manual/configuration/steps/shell_command.html

I originally opened a question for this (#5954) but was told to open a bug instead.
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Mar 29, 2021
@tonyhutter
Update buildbot to 3.0.4
67827e3 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.0.4.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and Ubuntu 20.04 setup instructions
  for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
@p12tic p12tic added the bug label Mar 31, 2021
@p12tic p12tic mentioned this issue Apr 4, 2021
Merged
@p12tic
Copy link
Member

p12tic commented Apr 4, 2021

@tonyhutter FYI the only thing what was broken was an argument allowlist. See 78fae50.

@tonyhutter
Copy link
Contributor Author

Thank you! 😄 👍

tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Jul 1, 2021
@tonyhutter
Update buildbot to 3.2.0
5ca593f 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and Ubuntu 20.04 setup instructions
  for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Jul 1, 2021
@tonyhutter
Update buildbot to 3.2.0
b533093 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and Ubuntu 20.04 setup instructions
  for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Aug 5, 2021
@tonyhutter
Update buildbot to 3.2.0
e7c71a9 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and Ubuntu 20.04 setup instructions
  for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Aug 6, 2021
@tonyhutter
Update buildbot to 3.2.0
fb06a34 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and setup instructions for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Aug 11, 2021
@tonyhutter
Update buildbot to 3.2.0
9b05123 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and setup instructions for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957
- Remove all patches except "Enable-run-time-AMI-determination.patch"
  since most of them have already been baked into upstream buildbot.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Aug 16, 2021
@tonyhutter
Update buildbot to 3.2.0
97b2256 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and setup instructions for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957
- Remove all patches except "Enable-run-time-AMI-determination.patch"
  since most of them have already been baked into upstream buildbot.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Aug 26, 2021
@tonyhutter
Update buildbot to 3.2.0
d537d3e 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and setup instructions for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957
- Remove all patches except "Enable-run-time-AMI-determination.patch"
  since most of them have already been baked into upstream buildbot.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Aug 31, 2021
@tonyhutter
Update buildbot to 3.2.0
aa344b1 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and setup instructions for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957
- Remove all patches except "Enable-run-time-AMI-determination.patch"
  since most of them have already been baked into upstream buildbot.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
behlendorf pushed a commit to openzfs/zfs-buildbot that referenced this issue Aug 31, 2021
@tonyhutter @behlendorf
Update buildbot to 3.2.0
18da2ed 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and setup instructions for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957
- Remove all patches except "Enable-run-time-AMI-determination.patch"
  since most of them have already been baked into upstream buildbot.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs-buildbot that referenced this issue Jul 13, 2022
@tonyhutter
Update buildbot to 3.2.0
6667353 
This patch does a number of things to update zfs-buildbot from
buildbot 0.8.x to 3.2.0.

- Remove old patchsets
- Use "worker" terminology to match new buildbot APIs.
- Make a bunch of previously hard-coded global variables optionally
  set-able in password.py (for testing only).
- Correctly name the coverage tester Ubuntu 17 instead of 18
- Add nginx config to README.md and setup instructions for buildbot.
- Fix get_freebsd_image(): 'NoneType' object has no attribute 'get_image'
- Base64 encode user_data to get around error
- Update block_device_map
- Integrate isIdle() patch into zfs-buildbot.  We no longer have an
  idle worker state, so just check to see if a builder is available.
- Get rid of: "logHorizon/buildHorizon is deprecated" warnings
- Get rid of special chars in worker names (like '.').  This gets
  around an error:
       "worker name '<worker name>' is not an identifier
- Fix auth/authz/www stuff
- Fix 'nextWorker now takes a 3rd argument'
- Fix error while parsing config file: cannot import name 'html'
- mergeRequests -> collapseRequests
- Make boot_device_map a list to match new API
- Fix "builtins.TypeError: __init__() takes at least 3 arguments"
- buildbot.status.results -> buildbot.process.results
- Misc other updates
- Remove 'lazylogfiles' due to buildbot bug:
  buildbot/buildbot#5957
- Remove all patches except "Enable-run-time-AMI-determination.patch"
  since most of them have already been baked into upstream buildbot.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up shell command tests and re-add support for lazylogfiles p12tic/buildbot
2 participants
@p12tic @tonyhutter