Trac #2660 [nine] buildrequests data API uses popBooleanFilter for non-booleans #1050
Conversation
…r for non-booleans - added data fields 'branch', 'repository', 'codebase' for buildrequests. updated the doc - added resultSpec.popStringFilter (popStringFilter == popBooleanFilter)
…r for non-booleans - This commit implements the 3 dustin's comments: - process buildsetid with the eq operator in the DB API - implement popStringFilter (only pops an eq filter) - add type annotation in master/docs/developer/database.rst
|
that's weird, the validate.sh script succeeds locally for: 36bd304 |
|
It's a docs build failure, fixed in 7ba629d. Is this ready to go, then? |
|
thanks dustin. Yes it's ready to go. |
| repository = resultSpec.popBooleanFilter('repository') | ||
| bsid = resultSpec.popFilter('buildsetid', 'eq') | ||
| if bsid: | ||
| bsid = bsid[0] |
There was a problem hiding this comment.
This looks good, although I wonder if popOneFilter would be even more convenient.
…r for non-booleans - omit filters 'branch' and 'repository' - use popOneFilter instead of popFilter for bsid
|
validate.sh succeeds locally for: cb004e0 |
| @@ -35,6 +35,9 @@ def db2data(self, dbdict): | |||
| 'claimed': dbdict['claimed'], | |||
| 'claimed_at': dbdict['claimed_at'], | |||
| 'claimed_by_masterid': dbdict['claimed_by_masterid'], | |||
| 'branch': dbdict['branch'], | |||
| 'repository': dbdict['repository'], | |||
| 'codebase': dbdict['codebase'], | |||
There was a problem hiding this comment.
The most recent changes look good, but this is still adding these three fields to the buildrequest data type, and they don't have much meaning since there can be multiple sourcestamps with different codebaess attached to a buildrequest.
|
I'll remove these 3 fields. |
…r for non-booleans - remove fieds: branch, repository, codebase
|
There's still a bunch of code, docs, and tests in here adding branch/repository/codebase for buildrequests. |
|
oups, I missed that. I'll try to have a look asap. |
|
ping.. looks like this one is nearly finished |
|
Indeed, but I have some much work. I'll try to finish this asap. I hope I can have a look at this next week. I'm really sorry for the delay. Xavier Sent from my iPhone
|
|
I, at least, can't complain about others being busy. But please do keep this somewhere on your to-do list :) |
…r for non-booleans - remove code in docs/tests about branch/repository/codebase for buildrequests
|
Looks great -- thanks for finding time! |
updated the doc
http://trac.buildbot.net/ticket/2660