Do not catch GeneratorExit exception #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On buildbot 0.8.8 in rare conditions, we hit:
File "/data/buildbot/twisted/internet/threads.py", line 49, in deferToThreadPool
threadpool.callInThreadWithCallback(onResult, f, *args, **kwargs)
File "/data/buildbot/twisted/python/threadpool.py", line 148, in callInThreadWithCallb
ack
self.q.put(o)
File "//usr/lib/python2.7/Queue.py", line 138, in put
self.not_empty.notify()
File "//usr/lib/python2.7/threading.py", line 392, in notify
for waiter in waiters:
--- <exception caught here> ---
File "/data/buildbot/buildbot/process/buildstep.py", line 605, in _startStep_3
result = yield defer.maybeDeferred(self.start)
exceptions.GeneratorExit:
this applies the fix from http://trac.buildbot.net/ticket/2395#comment:10 to master/buildbot/process/buildstep.py
|
Good call - we really should be searching and destroying bare excepts :( |
djmitche
added a commit
that referenced
this pull request
Jan 31, 2014
thinkski
pushed a commit
to kuna-systems/buildbot
that referenced
this pull request
Sep 10, 2014
ghost
pushed a commit
to tdctaz/katana
that referenced
this pull request
Aug 22, 2017
Fix a rare case where a buildtep might fail from a GeneratorExit exception (pull request 1063 (buildbot#1063)
tdctaz
pushed a commit
to tdctaz/katana
that referenced
this pull request
Aug 29, 2017
Fix a rare case where a buildtep might fail from a GeneratorExit exception (pull request 1063 (buildbot#1063)
tdctaz
pushed a commit
to tdctaz/katana
that referenced
this pull request
Sep 18, 2017
Fix a rare case where a buildtep might fail from a GeneratorExit exception (pull request 1063 (buildbot#1063)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On buildbot 0.8.8 in rare conditions, we hit:
File "/data/buildbot/twisted/internet/threads.py", line 49, in deferToThreadPool
threadpool.callInThreadWithCallback(onResult, f, _args, *_kwargs)
File "/data/buildbot/twisted/python/threadpool.py", line 148, in callInThreadWithCallb
ack
self.q.put(o)
File "//usr/lib/python2.7/Queue.py", line 138, in put
self.not_empty.notify()
File "//usr/lib/python2.7/threading.py", line 392, in notify
for waiter in waiters:
--- ---
File "/data/buildbot/buildbot/process/buildstep.py", line 605, in _startStep_3
result = yield defer.maybeDeferred(self.start)
exceptions.GeneratorExit:
this applies the fix from http://trac.buildbot.net/ticket/2395#comment:10 to master/buildbot/process/buildstep.py