Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not catch GeneratorExit exception #1063

Merged
merged 1 commit into from Jan 31, 2014

Conversation

Projects
None yet
2 participants
@chantra
Copy link
Contributor

chantra commented Jan 31, 2014

On buildbot 0.8.8 in rare conditions, we hit:

File "/data/buildbot/twisted/internet/threads.py", line 49, in deferToThreadPool
threadpool.callInThreadWithCallback(onResult, f, _args, *_kwargs)
File "/data/buildbot/twisted/python/threadpool.py", line 148, in callInThreadWithCallb
ack
self.q.put(o)
File "//usr/lib/python2.7/Queue.py", line 138, in put
self.not_empty.notify()
File "//usr/lib/python2.7/threading.py", line 392, in notify
for waiter in waiters:
--- ---
File "/data/buildbot/buildbot/process/buildstep.py", line 605, in _startStep_3
result = yield defer.maybeDeferred(self.start)
exceptions.GeneratorExit:

this applies the fix from http://trac.buildbot.net/ticket/2395#comment:10 to master/buildbot/process/buildstep.py

Do not catch GeneratorExit exception
On buildbot 0.8.8 in rare conditions, we hit:

File "/data/buildbot/twisted/internet/threads.py", line 49, in deferToThreadPool
      threadpool.callInThreadWithCallback(onResult, f, *args, **kwargs)
    File "/data/buildbot/twisted/python/threadpool.py", line 148, in callInThreadWithCallb
ack
      self.q.put(o)
    File "//usr/lib/python2.7/Queue.py", line 138, in put
      self.not_empty.notify()
    File "//usr/lib/python2.7/threading.py", line 392, in notify
      for waiter in waiters:
  --- <exception caught here> ---
    File "/data/buildbot/buildbot/process/buildstep.py", line 605, in _startStep_3
      result = yield defer.maybeDeferred(self.start)
  exceptions.GeneratorExit:

this applies the fix from http://trac.buildbot.net/ticket/2395#comment:10 to master/buildbot/process/buildstep.py
@djmitche

This comment has been minimized.

Copy link
Member

djmitche commented Jan 31, 2014

Good call - we really should be searching and destroying bare excepts :(

djmitche added a commit that referenced this pull request Jan 31, 2014

@djmitche djmitche merged commit 74b0b42 into buildbot:master Jan 31, 2014

1 check passed

default The Travis CI build passed
Details

@chantra chantra deleted the chantra:fb-master branch Jan 31, 2014

thinkski pushed a commit to kuna-systems/buildbot that referenced this pull request Sep 10, 2014

ghost pushed a commit to tdctaz/katana that referenced this pull request Aug 22, 2017

Applying fix from this PR:
Fix a rare case where a buildtep might fail from a GeneratorExit exception (pull request 1063
(buildbot#1063)

tdctaz pushed a commit to tdctaz/katana that referenced this pull request Aug 29, 2017

Applying fix from this PR:
Fix a rare case where a buildtep might fail from a GeneratorExit exception (pull request 1063
(buildbot#1063)

tdctaz pushed a commit to tdctaz/katana that referenced this pull request Sep 18, 2017

Applying fix from this PR:
Fix a rare case where a buildtep might fail from a GeneratorExit exception (pull request 1063
(buildbot#1063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.