Support tagging instances after they have launched.

[kouk]

This pull request adds support for tagging latent buildbot slaves on EC2. If this is something the buildbot devs think is a good idea I can write tests and documentation to make this pull request complete.

[djmitche]

What is the benefit? I'm not terribly familiar with using the latent slave facilities, so it's hard for me eto know if this is a good idea.

[kouk]

I use it so that I can tailor my AWS IAM security policies more flexibly. For example I can give the buildbot user a right to terminate only those instances that it launched and tagged.

[djmitche]

OK, sounds good -- want to add some documentation, tests, and an entry in the release notes?

[kouk]

sure, I have locally done documentation and release notes but I will also try adding some tests (currently there are none for EC2LatentBuildSlave or am I mistaken?)

[kouk]

The unit tests depend on this pull request in moto. With luck it will be merged and released soon and then these unit tests will pass as well.

[kouk]

Ooops, sorry about that rebase, I accidentally pushed some commits that were meant for my local use only.

[kouk]

So predictably the build failed because of the moto dependency in the EC2LatentBuildSlave unit tests I wrote. How would you like to proceed?

[tardyp]

you can skip them if moto is unavailable. see http step tests on how to do
it.. you can remove the dep from setup.py

Pierre

On Tue, Feb 25, 2014 at 11:59 AM, Konstantinos Koukopoulos <
notifications@github.com> wrote:

So predictably the build failed because of the moto dependency in the
EC2LatentBuildSlave unit tests I wrote. How would you like to proceed?

Reply to this email directly or view it on GitHubhttps://github.com//pull/1067#issuecomment-35996455
.

[djmitche]

Wow, this is awesome! We'll add moto to the metabuildbot so these tests will be run, but Pierre's right - if not present, just skip the tests, so that every user doesn't have to install moto.