Nine ui python #1090
Merged
Nine ui python #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 7, 2014 19:49
This is a new resource for buildset properties. There is also a placeholder for build properties, but this first needs a db change
This adds url to the db, with all the tests, and race condition handling
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
and supprt _add__ operator for it, so that description and descriptionSuffix can be concatenated unrendered yet Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
sa does not allow is None in the whereclauses, we create a simple null constant for usage inside the db apis Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
so that the sdist does not need node Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
|
updated PR. master housekeeping is cleaning out pending Builds and buildrequest upon stop and startup. Please tell if there is an objection on this. Also I added generic update events for buildrequests, so that the UI can watch buildrequest is the generic way. |
| name = types.String() | ||
| url = types.String() | ||
|
|
||
|
|
|
Looks good. A few minor things, but I think this is ready to merge. |
added 3 commits
March 11, 2014 15:45
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
We just describe a little bit later instead of accepting not rendered arguments Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
|
ok. I think I'm done on this one. I'll push that tomorrow to watch metabuildbot potencial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are some small python code changes I need to make progress on the UI.