update of the nine UI #1094
Merged
update of the nine UI #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tardyp
commented
Mar 14, 2014
tardyp
commented
- Refactor a lot, by creating services
- use angular-recursion instead of the recursive directive
- lots of unit tests added
- include underscore-string utils for string manipulations
- jasmine version bump
- fix console.log issue in karma
- automatic upgrade of the db is its on sqlite (it simplifies the heroku deployment a lot, as the db is squashed everytime you restart the app)
added 2 commits
March 11, 2014 17:44
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
- Refactor a lot, by creating services - use angular-recursion instead of the recursive directive - lots of unit tests added - include underscore-string utils for string manipulations - jasmine version bump - fix console.log issue in karma Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
| @@ -112,6 +112,8 @@ def setup(self, check_version=True, verbose=True): | |||
|
|
|||
| def check_current(res): | |||
| if not res: | |||
| if db_url.startswith("sqlite"): | |||
| return self.model.upgrade() | |||
There was a problem hiding this comment.
I don't think this is a good idea in production code. Could we add an option to 'buildbot start' to automatically upgrade the DB?
There was a problem hiding this comment.
well, for buildbot nine, we are going to rethink the db uprade completly. Can we report writting this option for this BZ? or I can just remove the commit
There was a problem hiding this comment.
err.. this breaks the unit tests anyway. I reverted it.
added 5 commits
March 14, 2014 18:34
This reverts commit 2e6c234.
The previous url was incorrectly using buildername http://trac.buildbot.net/ticket/2618 we hide this URL in the UI, this is only here in data api. Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.