Rename the 'path' argument of the MasterShellCommand 'workdir' #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could imagine having a transition period where both are allowed ... I'd rather not ... |
|
Oh, and saw it ? I'm trying to use git again ! |
|
LGTM. |
| @@ -103,7 +103,7 @@ def test_real_cmd_fails(self): | |||
| def test_constr_args(self): | |||
| self.setupStep( | |||
| master.MasterShellCommand(description='x', descriptionDone='y', | |||
| env={'a': 'b'}, path=['/usr/bin'], usePTY=True, | |||
| env={'a': 'b'}, workdir=['/usr/bin'], usePTY=True, | |||
There was a problem hiding this comment.
These are definitely wrong - http://twistedmatrix.com/documents/current/api/twisted.internet.interfaces.IReactorProcess.spawnProcess.html says path is the working directory in which to run the command -- not a list.
|
Other than the test fixes, yeah -- this just needs docs and a release note. |
|
I believe this is ok now. |
|
👍 |
sa2ajj
pushed a commit
that referenced
this pull request
Oct 28, 2014
Rename the 'path' argument of the MasterShellCommand 'workdir' - All other steps take a workdir - The path argument is not mentioned in the doc - Even worse, the doc has an example: command="cd dir; do stuff" - As the test show, the one that wrote it believed it would become the PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few considerations: