Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for trac:2978 #1313

Merged
merged 3 commits into from Nov 2, 2014
Merged

fix for trac:2978 #1313

merged 3 commits into from Nov 2, 2014

Conversation

tardyp
Copy link
Member

@tardyp tardyp commented Nov 1, 2014 

resultspec: treats None as smaller to anything

This avoids useless 500 when the data set contains
null datetimes

Pierre Tardy added 2 commits November 1, 2014 15:45
resultspec: treats None as smaller to anything
e2ef9a2 
This avoids useless 500 when the data set contains
null datetimes
test for null datetime sorting
0cae391
benallard
benallard reviewed Nov 1, 2014
View reviewed changes
master/buildbot/test/unit/test_data_resultspec.py
data = mklist(('fn', 'ln'),
('cedric', None),
('albert', datetime.datetime(1, 1, 1)))
resultspec.ResultSpec(order=['ln']).apply(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to check the result of the sorting ?

@djmitche
Copy link
Member

djmitche commented Nov 1, 2014

It seems silly, but nonecmp should probably have a few unit tests to exercise it fully. It's always the simple functions that have the bugs!

more tests for resultsspec's nonecmp
6d2f209 
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
@tardyp
Copy link
Member Author

tardyp commented Nov 2, 2014

more tests

@benallard
Copy link
Contributor

Looks good.

@sa2ajj
Copy link
Contributor

sa2ajj commented Nov 2, 2014

👍

I wonder where's coveralls information...

@sa2ajj sa2ajj added the merge-me label Nov 2, 2014
sa2ajj pushed a commit that referenced this pull request Nov 2, 2014
Merge pull request #1313 from tardyp/t2978
0132c9a 
Fix: Loading the waterfall while a build is in progress return 500

Fixes ticket:2978
@sa2ajj sa2ajj merged commit 0132c9a into buildbot:master Nov 2, 2014
@benallard
Copy link
Contributor

@sa2ajj coveralls commenting has been disabled by @djmitche.

@sa2ajj
Copy link
Contributor

sa2ajj commented Nov 2, 2014

Oh, it was probably discussed on the IRC...

@tardyp tardyp deleted the t2978 branch April 24, 2016 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tardyp @djmitche @benallard @sa2ajj