Use guanlecoja-ui contextual actions for forceschedulers #1348
Conversation
- remove previous unwired contextual actions (promote/rebuild) - remove useless rawdata in build page partially solve buildbot#2995: Get rid of all the broken / unwired elements from the web UI.
|
I need to look at it more closer, but if it does what I think, i believe I like it already ! |
| @@ -14,6 +15,23 @@ class Builder extends Controller | |||
| recentStorage.addBuilder | |||
| link: "#/builders/#{$scope.builder.builderid}" | |||
| caption: $scope.builder.name | |||
| builder.all('forceschedulers').bind($scope) | |||
|
|
|||
| # reinstall breadcrumb when coming back from forcesched | |||
There was a problem hiding this comment.
Why does forcesched removes it at all ?
There was a problem hiding this comment.
This is indeed a bit tricky..
The breadcrumb and context actions are reset at each $state change.
With ui-router, states can be nested. In order to make forceschedulers bookmarkable, they are actually a sub state of builder. So going to forcesched and backward will reset the $state without reloading the controller. Hence the controller must watch this out.
$scope.$on watches until the scope is destroyed, that is when we are going out of the state.
There was a problem hiding this comment.
Maybe the kern of the trouble is to make a modal dialog bookmark-able ...
There was a problem hiding this comment.
The problem would be valid for all nested states, even if forcesched dialog is the only use case I can see now.
This is an important usecase for me to be able to integrate forcebuilds with other web applications.
E.g from a bug tracker, you want to check a bunch of bugs that are in implemented states, click a button, go directly to the buildbot forcesched form, select a bunch of additional tests (via a forcesched parameter plugin, which queries the test plan REST api), and create an android build with the patches associated to the bugs + run the tests.
|
Note that this does also solves (as in removes) TRAC-2954. Good work ! |
|
Is it good to be merged? |
|
@sa2ajj for me its good for merge |
Use guanlecoja-ui contextual actions for forceschedulers See ticket:2995, ticket:2954
partially solve #2995:
Get rid of all the broken / unwired elements from the web UI.