Trial: Improve memory handling ... #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| stream, line = yield | ||
|
|
||
| def createSummary(self, loog): | ||
| problems = self.problems | ||
| problems = '\n'.join(self.problems) |
There was a problem hiding this comment.
I forgot to make one comment: the resulting problems will not have trailing \n. If it's intended, I'll merge it.
There was a problem hiding this comment.
Logs are not intended to be machine parse able. Hence I think it's no problem.
There was a problem hiding this comment.
I was thinking about the change that was introduced in #1436
There was a problem hiding this comment.
@sa2ajj: Because of that trailing '\n', that bug was discovered. But in no way, a trailing '\n' is needed.
sa2ajj
pushed a commit
that referenced
this pull request
Dec 11, 2014
Trial: Improve memory handling ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.