test_stop_trigger: fix remote_interruptCommand no attribute error #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetanotherion
force-pushed
the
master
branch
3 times, most recently
from
fc36e16
to
7c9a059
Compare
yetanotherion
changed the title
added 2 commits
May 22, 2015 10:07
This commit adds a test to reproduce the remote_interruptCommand no attribute error.
The rpc method can be directed to two type of objects:
- slave.buildslave.base.BotBase, or
- SlaveBuilder, that is contained on the previous object
inside a dictionary {buildername: SlaveBuilder}.
Currently, the remote interruptCommand rpc is directed
to the slave.buildslave.base.Botbase. However this
object does not have any interruptCommand method,
only the SlaveBuilder has it.
Moreover, the current prototype of the method remoteInterruptCommand
- (commandId, why)
does not permit to find the associated SlaveBuidler to which
the rpc should be directed to.
This commit implements:
- a change of the prototype to the remoteInterruptCommand method
to add the builderName, i.e (builderName, commandId, why)
- a redirection of the interruptCommand rpc, to the SlaveBuilder.
|
cool fix! 👍 |
sa2ajj
pushed a commit
that referenced
this pull request
May 22, 2015
test_stop_trigger: fix remote_interruptCommand no attribute error
|
Yay! |
|
@yetanotherion, the change to |
|
@djmitche my mistake, http://trac.buildbot.net/ticket/3266 |
|
great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current execution of buildbot.test.integration.test_stop_trigger.TriggeringMaster.testTriggerRunsForever
fail randomly, due to different scenarios being executed. They differentiate on whether:
This PR aims at fixing the error.