Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: skip fetch if the revision already exists #1735

Merged
merged 1 commit into from Jun 28, 2015

Conversation

jaredgrubb
Copy link
Member

Background: I am working on a "richer" git experience with buildbot, where I can reliably get tags, work with multiple remote servers (for the same repo), and share git-objects on the slaves to avoid multiple builders doing redundant network fetches.

The current Git step is not quite sufficient because it seems (correct me if I'm wrong) to take a conservative view of working with a git-server: to only fetch the minimal amount needed.

So, this patch doesnt actually fix anything, so maybe it's not worth taking. But I thought I would post it.

@sa2ajj
Copy link
Contributor

sa2ajj commented Jun 22, 2015

PEP8:

master/buildbot/steps/source/git.py:368:18: E225 missing whitespace around operator
            if rc==RC_SUCCESS:
                 ^
1       E225 missing whitespace around operator
1
make: *** [pep8] Error 1

@sa2ajj
Copy link
Contributor

sa2ajj commented Jun 22, 2015

This looks a bit cleaner for me.

👍

@jaredgrubb
Copy link
Member Author

Pushed the pep8 fix.

sa2ajj pushed a commit that referenced this pull request Jun 28, 2015
git: skip fetch if the revision already exists
@sa2ajj sa2ajj merged commit 6295d9f into buildbot:master Jun 28, 2015
sa2ajj pushed a commit that referenced this pull request Jul 6, 2015
Eight backport of request #1735: git no-refetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants