Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybeStartBuildsForSlave after insubstantiating #1831

Merged
merged 1 commit into from Aug 30, 2015

Conversation

djmitche
Copy link
Member

(also handle the deferred from self.insubstantiate elsewhere)

(also handle the deferred from self.insubstantiate elsewhere)
@djmitche
Copy link
Member Author

(this easily cherry-picks onto the eight branch)

@codecov-io
Copy link

Current coverage is 84.79%

Merging #1831 into master will decrease coverage by -0.01% as of 2c0c800

@@            master   #1831   diff @@
======================================
  Files          344     344       
  Stmts        31831   31833     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit          26993   26994     +1
  Partial          0       0       
- Missed        4838    4839     +1

Review entire Coverage Diff as of 2c0c800


Uncovered Suggestions

  1. +0.11% via ...ot/status/builder.py#381...414
  2. +0.09% via ...ot/status/builder.py#453...481
  3. +0.09% via ...dbot/changes/mail.py#478...505
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@jaredgrubb
Copy link
Member

LGTM!

sa2ajj pushed a commit that referenced this pull request Aug 30, 2015
maybeStartBuildsForSlave after insubstantiating
@sa2ajj sa2ajj merged commit 7be0a1c into buildbot:master Aug 30, 2015
sa2ajj pushed a commit that referenced this pull request Aug 31, 2015
Backport GH-1831 to 0.8.x: maybeStartBuildsForSlave after insubstantiating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants