Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sanity check for parameter for CaptureBuildDuration. #1839

Merged
merged 1 commit into from
Sep 6, 2015

Conversation

prasoon2211
Copy link
Contributor

Added sanity check for report_in parameter in CaptureBuildDuration according to the commit message prasoon2211@64e0917#commitcomment-12982136 for PR #1824

@codecov-io
Copy link

Current coverage is 84.55%

Merging #1839 into master will not affect coverage as of 6bede93

@@            master   #1839   diff @@
======================================
  Files          320     320       
  Stmts        31105   31108     +3
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit          26300   26302     +2
  Partial          0       0       
- Missed        4805    4806     +1

Review entire Coverage Diff as of 6bede93


Uncovered Suggestions

  1. +0.10% via ...ot/status/builder.py#381...414
  2. +0.09% via ...ot/status/builder.py#453...481
  3. +0.09% via ...dbot/changes/mail.py#478...505
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@prasoon2211
Copy link
Contributor Author

@sa2ajj @stibbons Please review.

sa2ajj pushed a commit that referenced this pull request Sep 6, 2015
Added sanity check for  parameter for CaptureBuildDuration.
@sa2ajj sa2ajj merged commit 21cad31 into buildbot:master Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants