New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document BUILDBOT_TEST_DB_URL + provide example of using DB from Docker #1955
Conversation
TODO note at the end about not working MySQL 5.7 may be replaced with note that "MySQL 5.7 is currently unsupported, see issue #..." and appropriate issue on Buildbot bug tracker can be created. |
Current coverage is
|
Testing migrations with real databases | ||
-------------------------------------- | ||
|
||
By default Buildbot test suite uses SQLite database for testings database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not comply with one-sentence-per-line policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked section above for that style policy --- it doesn't follow it either :)
It's a good policy IMO. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been updating the docs to make it compliant. Not all of it is though :(
I think an issue and a link to it is the way to go. |
I replaced TODO note with a link on http://trac.buildbot.net/ticket/3421. |
LGTM! |
@sa2ajj I resolved all stated issues, maybe merge? |
.. note:: | ||
|
||
Currently Buildbot doesn't work with MySQL 5.7 Docker image, see issue | ||
:bug:`3421`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, in fact BB's not compatible with 5.7 at all at the moment.
Document BUILDBOT_TEST_DB_URL + provide example of using DB from Docker
No description provided.