Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document BUILDBOT_TEST_DB_URL + provide example of using DB from Docker #1955

Merged
merged 5 commits into from Feb 9, 2016

Conversation

rutsky
Copy link
Member

@rutsky rutsky commented Jan 24, 2016

No description provided.

@rutsky
Copy link
Member Author

rutsky commented Jan 24, 2016

TODO note at the end about not working MySQL 5.7 may be replaced with note that "MySQL 5.7 is currently unsupported, see issue #..." and appropriate issue on Buildbot bug tracker can be created.

@codecov-io
Copy link

Current coverage is 84.57%

Merging #1955 into master will not affect coverage as of 802605f

@@            master   #1955   diff @@
======================================
  Files          320     320       
  Stmts        31151   31151       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit          26347   26347       
  Partial          0       0       
  Missed        4804    4804       

Review entire Coverage Diff as of 802605f


Uncovered Suggestions

  1. +0.11% via ...ot/status/builder.py#381...414
  2. +0.10% via ...ot/status/builder.py#453...481
  3. +0.09% via ...dbot/changes/mail.py#478...505
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

Testing migrations with real databases
--------------------------------------

By default Buildbot test suite uses SQLite database for testings database
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not comply with one-sentence-per-line policy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked section above for that style policy --- it doesn't follow it either :)
It's a good policy IMO. Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been updating the docs to make it compliant. Not all of it is though :(

@sa2ajj
Copy link
Contributor

sa2ajj commented Jan 24, 2016

I think an issue and a link to it is the way to go.

@rutsky
Copy link
Member Author

rutsky commented Jan 24, 2016

I replaced TODO note with a link on http://trac.buildbot.net/ticket/3421.

@tardyp
Copy link
Member

tardyp commented Jan 26, 2016

LGTM!

@rutsky
Copy link
Member Author

rutsky commented Jan 28, 2016

@sa2ajj I resolved all stated issues, maybe merge?

.. note::

Currently Buildbot doesn't work with MySQL 5.7 Docker image, see issue
:bug:`3421`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, in fact BB's not compatible with 5.7 at all at the moment.

rutsky added a commit that referenced this pull request Feb 9, 2016
Document BUILDBOT_TEST_DB_URL + provide example of using DB from Docker
@rutsky rutsky merged commit 53f4aa3 into buildbot:master Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants