Upgrade pip in travis. #2227
Merged
Upgrade pip in travis. #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @djmitche, @stevepeak and @rutsky to be potential reviewers |
| - "echo 'travis_fold:start:codecov'; pip install codecov; echo 'travis_fold:end:codecov'" | ||
| - "echo 'travis_fold:start:tw'; [ $TWISTED = latest ] || pip install Twisted==$TWISTED; echo 'travis_fold:end:tw'" | ||
| - "echo 'travis_fold:start:sa'; [ $SQLALCHEMY = latest ] || pip install sqlalchemy==$SQLALCHEMY; echo 'travis_fold:end:sa'" | ||
| - pip install codecov |
There was a problem hiding this comment.
Travis automatically folds individual install steps, so folding again inside the step is a waste (and just makes seeing the contents of the fold more annoying).
tomprince
force-pushed
the
upgrade-pip-for-wheel-caches
branch
from
4fc6827
to
b917e97
Compare
|
Note that because of how cache inheritance works, this will probably only show a benefit after a build of this on master. |
|
Nice side effect: after removing folding we see that there were actually an error: https://travis-ci.org/buildbot/buildbot/jobs/129764461#L334 We need to add |
rutsky
added a commit
that referenced
this pull request
May 12, 2016
Output will be collapsed for the same reason as in PR #2227. Previously if some of testing steps failed `pip list` command is not issued at all.
|
Updated to (hopefully) fix the build. |
| @@ -77,20 +77,22 @@ matrix: | |||
| fast_finish: true | |||
| include: | |||
| # Tests of buildbot-worker and buildbot-slave on python 2.6 | |||
| # Specify SQLALCHEMY=latest to avoid errors installling. | |||
tomprince
force-pushed
the
upgrade-pip-for-wheel-caches
branch
from
11786c9
to
5338e07
Compare
lopter
added a commit
to lopter/buildbot
that referenced
this pull request
Jul 5, 2016
Starting a Twisted reactor within a Mercurial hook is problematic because a hook can get called multiple times (from the same Mercurial process) which conflicts with the one-time only nature of the Twisted reactor start/stop calls. By moving to HTTP requests the hook is now re-entrant which fixes ReactorNotRestartable exceptions being raised all the time. The requests library is used to make the calls, since it has a functional TLS implementation (unlike urllib/httplib in Python 2).
lopter
added a commit
to lopter/buildbot
that referenced
this pull request
Jul 5, 2016
Starting a Twisted reactor within a Mercurial hook is problematic because a hook can get called multiple times (from the same Mercurial process) which conflicts with the one-time only nature of the Twisted reactor start/stop calls. By moving to HTTP requests the hook is now re-entrant which fixes ReactorNotRestartable exceptions being raised all the time. The requests library is used to make the calls, since it has a functional TLS implementation (unlike urllib/httplib in Python 2). Additionally, the codebase argument is added to the base ChangeHook, so it can properly be used with a codebaseGenerator.
lopter
added a commit
to lopter/buildbot
that referenced
this pull request
Jul 5, 2016
Starting a Twisted reactor within a Mercurial hook is problematic because a hook can get called multiple times (from the same Mercurial process) which conflicts with the one-time only nature of the Twisted reactor start/stop calls. By moving to HTTP requests the hook is now re-entrant which fixes ReactorNotRestartable exceptions being raised all the time. The requests library is used to make the calls, since it has a functional TLS implementation (unlike urllib/httplib in Python 2 until recently). Additionally, the codebase argument is added to the base ChangeHook, so it can properly be used with a codebaseGenerator. Finally, if a venv argument is used, it is now properly used to activate the environment [1]. Possible improvements to this changeset are: - send requests in parallel; - switch back to urllib2 so the hook doesn't depend on anything; - a few more cleanups. [1] https://github.com/pypa/virtualenv/blob/master/virtualenv_embedded/activate_this.py
lopter
added a commit
to lopter/buildbot
that referenced
this pull request
Jul 5, 2016
Starting a Twisted reactor within a Mercurial hook is problematic because a hook can get called multiple times (from the same Mercurial process) which conflicts with the one-time only nature of the Twisted reactor start/stop calls. By moving to HTTP requests the hook is now re-entrant which fixes ReactorNotRestartable exceptions being raised all the time. The requests library is used to make the calls, since it has a functional TLS implementation (unlike urllib/httplib in Python 2 until recently). Additionally, the codebase argument is added to the base ChangeHook, so it can properly be used with a codebaseGenerator. Finally, if a venv argument is used, it is now properly used to activate the environment [1]. Possible improvements to this changeset are: - send requests in parallel; - switch back to urllib2 so the hook doesn't depend on anything; - a few more cleanups. [1] https://github.com/pypa/virtualenv/blob/master/virtualenv_embedded/activate_this.py
lopter
added a commit
to lopter/buildbot
that referenced
this pull request
Jul 5, 2016
Starting a Twisted reactor within a Mercurial hook is problematic because a hook can get called multiple times (from the same Mercurial process) which conflicts with the one-time only nature of the Twisted reactor start/stop calls. By moving to HTTP requests the hook is now re-entrant which fixes ReactorNotRestartable exceptions being raised all the time. The requests library is used to make the calls, since it has a functional TLS implementation (unlike urllib/httplib in Python 2 until recently). Additionally, the codebase argument is added to the base ChangeHook, so it can properly be used with a codebaseGenerator. Finally, if a venv argument is used, it is now properly used to activate the environment [1]. Possible improvements to this changeset are: - send requests in parallel; - switch back to urllib2 so the hook doesn't depend on anything; - a few more cleanups. [1] https://github.com/pypa/virtualenv/blob/master/virtualenv_embedded/activate_this.py
lopter
added a commit
to lopter/buildbot
that referenced
this pull request
Jul 6, 2016
Starting a Twisted reactor within a Mercurial hook is problematic because a hook can get called multiple times (from the same Mercurial process) which conflicts with the one-time only nature of the Twisted reactor start/stop calls. By moving to HTTP requests the hook is now re-entrant which fixes ReactorNotRestartable exceptions being raised all the time. The requests library is used to make the calls, since it has a functional TLS implementation (unlike urllib/httplib in Python 2 until recently). Additionally, the codebase argument is added to the base ChangeHook, so it can properly be used with a codebaseGenerator. Finally, if a venv argument is used, it is now properly used to activate the environment [1]. Possible improvements to this changeset are: - send requests in parallel; - switch back to urllib2 so the hook doesn't depend on anything; - a few more cleanups. [1] https://github.com/pypa/virtualenv/blob/master/virtualenv_embedded/activate_this.py
sa2ajj
pushed a commit
that referenced
this pull request
Jul 6, 2016
Move to a ChangeHook in hgbuildbot.py (closes #2227)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer pip will cache wheels for installed packages, which should speed up the build.