Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify remoteGetWorkerInfo logic #2236

Merged
merged 1 commit into from Jun 5, 2016

Conversation

rutsky
Copy link
Member

@rutsky rutsky commented May 29, 2016

retrieve "slave_commands" and "version" only when old buildslave is
detected.

retrieve "slave_commands" and "version" only when old buildslave is
detected.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @MichaelMayorov, @tardyp and @djmitche to be potential reviewers

@codecov-io
Copy link

Current coverage is 85.10%

Merging #2236 into master will increase coverage by <.01%

@@             master      #2236   diff @@
==========================================
  Files           334        334          
  Lines         32098      32099     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          27316      27317     +1   
  Misses         4782       4782          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by fcba050...f77671a

@djmitche
Copy link
Member

So, for new workers the getWorkerInfo call includes all of this?

+1!

@rutsky
Copy link
Member Author

rutsky commented May 31, 2016

@djmitche yes, new buildbot-worker (and latest versions of buildslave) get all info in single getWorkerInfo() (getSlaveInfo()) call.
I haven't noticed that when previously changed this function, so simplifying logic now.

@tardyp tardyp merged commit 4098ee6 into buildbot:master Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants