Warn about ignored buildHorizon and logHorizion. #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.93%@@ master #2292 diff @@
==========================================
Files 345 345
Lines 33454 33456 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 28415 28417 +2
Misses 5039 5039
Partials 0 0
|
|
Indeed, for me this is an important feature for 0.9.1 I would rather keep it like this, with a compatibility warning |
tomprince
force-pushed
the
unused-horizons
branch
from
9a5abd7
to
11c9f62
Compare
tomprince
changed the title
|
I've update the patch to warn that the configuration is currently ignored, pointing at the ticket. |
tomprince
force-pushed
the
unused-horizons
branch
from
11c9f62
to
9841aba
Compare
I could swear I saw in the deleted lines of your first version a similar warning. |
|
The original version said they were ignored due to being deprecated. The new one due to a missing feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't currently used, but they could be supported in the database. Either we should get rid of them, or open a ticket to add back support (and probably document that they aren't currently working).