Fixes for hyper and latent worker #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopping when removed from config via reconfigure - few cleanups with regards to status API - real fix is to keep a reference to the master so that the unconfigured workers can asynchronously finish their builds properly
|
@tardyp, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rutsky, @delanne and @tomprince to be potential reviewers |
Current coverage is 86.05% (diff: 100%)@@ master #2325 diff @@
==========================================
Files 294 294
Lines 30529 30541 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 26274 26281 +7
- Misses 4255 4260 +5
Partials 0 0
|
| yield child.disownServiceParent() | ||
| # HACK: we still keep a reference to the master for some cleanup tasks which are not waited by | ||
| # to stopService (like the complex worker disconnection mechanism) | ||
| child.parent = self.master |
There was a problem hiding this comment.
Yuck :)
Can you leave a link to the relevant trac bugs?
|
Aside from the comment, I think this is a good fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more fixes for the latent worker framework, while I continue the integration, and tests.