Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant Development and Testing #2565

Closed
wants to merge 1 commit into from

Conversation

nand0p
Copy link
Contributor

@nand0p nand0p commented Jan 5, 2017

Vagrant assists with buildbot development and testing.

Ensures master and worker are working as expected from
a configurable buildbot fork and branch, and runs test suite.

@mention-bot
Copy link

@nand0p, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ashcrow, @tardyp and @rutsky to be potential reviewers.

@tardyp
Copy link
Member

tardyp commented Jan 6, 2017

I am not sure how vagrant could be better than a simple virtualenv development environment.
How fast is the development loop with this?

If you really insist on having a fully independent local test environment, there is buildbot_travis runner:

bbtravis run -j4 --docker-image buildbot/metabbotcfg

This will run the officially maintained tests using. It works well, but I don't really use it as he virtualenv setup is much more simple, integrated with editors, etc.

@nand0p
Copy link
Contributor Author

nand0p commented Jan 6, 2017

The advantage of this is it allows you to easily pull and test from a specified buildbot fork/branch. It also automates the process of creating master.cfg for testing, and ensures master comes up correctly and tests worker registers with master successfully. It also eliminates any issues with developing on OSX with virtualenv.

I find this useful, but if this is not deemed appropriate, i will close this PR. Please advise.

Vagrant assists with buildbot development and testing.

Ensures master and worker are working as expected from
a configurable buildbot fork and branch, and runs test suite.
@tardyp
Copy link
Member

tardyp commented Jan 6, 2017

  • for testing any fork/branch you just need to push a PR, and our CI infra will run the test suite in 21 different configurations
  • We already have automatic e2e master creation in the smokes directory, with protractor driven UI tests
  • what is the issue with osx virtualenv? I am writing all my contributions on osx without any issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants