Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RUN_FLAKY_TESTS requirements for a few tests. #2659

Merged
merged 2 commits into from Jan 24, 2017
Merged

Remove RUN_FLAKY_TESTS requirements for a few tests. #2659

merged 2 commits into from Jan 24, 2017

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Jan 23, 2017

Unicode fixes for Python 3 have fixed these tests on Python 2.

Fixes: #3339

@mention-bot
Copy link

@rodrigc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @djmitche, @tardyp and @bukzor to be potential reviewers.

@tardyp
Copy link
Member

tardyp commented Jan 23, 2017

@rodrigc #3339 is not about u'xx' vs 'xx' it is about

log:stdio (0)\n

vs

log:stdio (29)

but there have been changes since on the log system, and maybe this is more reliable (notably there is no more a timing when compressing logs where the log line count comes to zero)

Unicode fixes for Python 3 have fixed these tests on Python 2.

Fixes: #3339
@tardyp tardyp merged commit 340ae14 into buildbot:master Jan 24, 2017
@rodrigc rodrigc deleted the flaky branch January 24, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

canStartBuild example (RemoteCommand) does not work
3 participants