Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the tests for the waterfall web part #2676

Merged
merged 1 commit into from Jan 27, 2017
Merged

Conversation

desurd
Copy link
Contributor

@desurd desurd commented Jan 25, 2017

Signed-off-by: desurd david.desurmont@gmail.com

Remove this paragraph

Please have a look at our developer documentation before submitting your Pull Request.

http://trac.buildbot.net/wiki/Development
And especially:
http://trac.buildbot.net/wiki/SubmittingPatches

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragment directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

localBuilder.click()
self.checkBuilder(str)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much spaces

self.goBuild()
self.checkBuildResult()

goBuilder: (builderRef) ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be called goBuilderAndCheck

Signed-off-by: desurd <david.desurmont@gmail.com>
@tardyp tardyp merged commit ab0e79a into buildbot:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants