test_checkconfig: always create different config dir #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for python3 It looks like python3 added some optimization for the import method. both tests are importing files from _trialtemp/configdir , but between the two tests, the list available modules actually change. In the second test however, if you run from within the same python runtime, then python won't look again at the directory, and thus wont see it has changed since last time. So it will not find the new module. If we change 'configdir' with mkstemp, then it will work. also remove a warning from https://twistedmatrix.com/trac/ticket/9023#ticket
rodrigc
reviewed
Feb 1, 2017
| @@ -119,3 +119,6 @@ | |||
|
|
|||
| # FIXME: needs to be sorted out (#3666) | |||
| warnings.filterwarnings('ignore', "Invalid utf8 character string") | |||
|
|
|||
| # twisted.compat.execfile is using 'U' https://twistedmatrix.com/trac/ticket/9023 | |||
There was a problem hiding this comment.
This is triggering lint errors. Not sure what you want to do here, but I say to waste less time,
leave it out, and for now only test Py3 against Twisted from trunk.
There was a problem hiding this comment.
I think it is important to keep the comment. the spellcheck linter must not encourage us to write less comments! @rutsky
There was a problem hiding this comment.
@rodrigc next time please add exceptions for those words to https://github.com/buildbot/buildbot/blob/master/common/code_spelling_ignore_words.txt
rodrigc
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for python3
It looks like python3 added some optimization for the import method.
both tests are importing files from _trialtemp/configdir , but between the two tests, the list available modules actually change.
In the second test however, if you run from within the same python runtime, then python won't look again at the directory, and thus wont see it has changed since last time.
So it will not find the new module. If we change 'configdir' with mkstemp, then it will work.
also remove a warning from https://twistedmatrix.com/trac/ticket/9023#ticket