fix the usePTY feature #3054
Merged
fix the usePTY feature #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tardyp
commented
Mar 20, 2017
| @@ -248,7 +248,7 @@ def buildCommandKwargs(self, warnings): | |||
|
|
|||
| # check for the usePTY flag | |||
| if 'usePTY' in kwargs and kwargs['usePTY'] is not None: | |||
| if self.workerVersionIsOlderThan("svn", "2.7"): | |||
| if self.workerVersionIsOlderThan("shell", "2.7"): | |||
There was a problem hiding this comment.
This shall not change anything as buildbot worker advertise versions for '*', just fix it for coherency
There was a problem hiding this comment.
actually, reporter says that this change did matter.
because there is no "svn" command anymore in the worker package
I looked for other lines with the same problem, and there is none.
some people have reported the usePTY feature to not work. This is a unit test and integration test to make sure it actually works test is only for posix
Codecov Report
@@ Coverage Diff @@
## master #3054 +/- ##
=========================================
- Coverage 88.28% 88% -0.29%
=========================================
Files 314 314
Lines 32899 32899
=========================================
- Hits 29046 28952 -94
- Misses 3853 3947 +94
Continue to review full report at Codecov.
|
rutsky
reviewed
Mar 20, 2017
|
|
||
|
|
||
| # This integration test creates a master and worker environment, | ||
| # with one builders and a shellcommand step |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some people have reported the usePTY feature to not work.
This is a unit test and integration test to make sure it actually works
test is only for posix