Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix E741 on test_process_build #3107

Merged
merged 1 commit into from Apr 12, 2017
Merged

fix E741 on test_process_build #3107

merged 1 commit into from Apr 12, 2017

Conversation

tardyp
Copy link
Member

@tardyp tardyp commented Apr 8, 2017

recent pep8 does not like l (the letter) as a variable because some fonts make it undistinguishable from 1 (the number).

recent pep8 does not like l (the letter) as a variable because some fonts make it undistinguishable from 1 (the number).
@mention-bot
Copy link

@tardyp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hborkhuis, @mozbhearsum and @rutsky to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 8, 2017

Codecov Report

Merging #3107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3107   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files         314      314           
  Lines       32927    32927           
=======================================
  Hits        29072    29072           
  Misses       3855     3855

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5986c3d...b5f5453. Read the comment docs.

Copy link
Member

@seankelly seankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only usage of l?

Grepping the source and I see references all over the codebase. I wonder why this file is the only spot that needs fixing.

@tardyp
Copy link
Member Author

tardyp commented Apr 9, 2017

@seankelly no, its just that I worked on this file as part of #3103 and my editor pointed a bunch of pep8 errors. I then did feel like putting that patch in #3103

I feel like fixing the whole codebase is much annoying job, and I would prefer to fix it part by part.

@tardyp tardyp merged commit 6495e69 into buildbot:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants