Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv: upgrade setuptools to avoid errors #3118

Merged
merged 1 commit into from Apr 14, 2017

Conversation

rjarry
Copy link
Contributor

@rjarry rjarry commented Apr 14, 2017

Fix the following error seen on debian 8 (jessie):

$ make virtualenv
[...]
error in buildbot setup command: 'extras_require' must be a
dictionary whose values are strings or lists of strings containing
valid project/version requirement specifiers.

The distro version of setuptools is old: 5.5.1, upgrading it in the virtualenv fixes the issue.

Fix the following error seen on debian 8 (jessie):

  $ make virtualenv
  [...]
  error in buildbot setup command: 'extras_require' must be a
  dictionary whose values are strings or lists of strings containing
  valid project/version requirement specifiers.

The distro version of setuptools is old: 5.5.1, upgrading it in the
virtualenv fixes the issue.

Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
@mention-bot
Copy link

@robin-jarry, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tardyp, @rutsky and @benallard to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 14, 2017

Codecov Report

Merging #3118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3118   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files         314      314           
  Lines       32986    32986           
=======================================
  Hits        29133    29133           
  Misses       3853     3853

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4e6b2...d2b9a0b. Read the comment docs.

@rutsky rutsky requested review from tardyp and removed request for tardyp April 14, 2017 16:43
@tardyp tardyp merged commit e6fb787 into buildbot:master Apr 14, 2017
@rjarry rjarry deleted the venv-setuptools-upgrade branch April 14, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants