Fix login issues on py3 and recent chrome #3145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues at the same time
e2e tests were sometimes broken on the cloud because xvfb screen was smaller than what is tested locally, clicked elements were not always visible on screen.
people reported issues with basic auth. Looks like this is because of a new CORS restriction enforced by new browsers. For this reason, we should release quite soon because people will see the issue more and more thanks to progressive update of browsers.
because of the urgency, I backported the twisted fix as a monkey patch for py3, so that people can continue to test py3 with auth enabled. The fix is tested with e2e py3 but coverage is not enabled for those tests.
e2e tests now does a basic authentication. @desurd can now finish its wider authz e2e tests.