cmake: allow renderables in definition/options #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3156 +/- ##
==========================================
+ Coverage 88.06% 88.06% +<.01%
==========================================
Files 314 314
Lines 33046 33047 +1
==========================================
+ Hits 29101 29102 +1
Misses 3945 3945
Continue to review full report at Codecov.
|
seankelly
reviewed
Apr 27, 2017
master/buildbot/steps/cmake.py
Outdated
| from buildbot.process.buildstep import BuildStep | ||
| from buildbot.process.buildstep import ShellMixin | ||
| from buildbot.process.properties import Property |
There was a problem hiding this comment.
This import isn't used, so it needs to be removed.
| self.properties.setProperty('b', {'a': b_value}, source='test') | ||
| self.expect_and_run_command('-D%s=%s' % ('a', b_value)) | ||
|
|
||
|
|
There was a problem hiding this comment.
One too many blank lines here.
noc0lour
force-pushed
the
make_cmake_renderable
branch
from
8598c10
to
bfd1e44
Compare
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows putting in real renderables in the CMake step.